Eliminate unsafe_write_num_bytes and thus unsafe block inside of it #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsafe_write_num_bytes macro can be replaced by a perfectly safe code which uses `n::to_xx_bytes()` to convert given number to desired representation and `buf[..N].copy_from_slice(...)` which writes that into the buffer.
BurntSushi
pushed a commit
that referenced
this pull request
Oct 5, 2023
unsafe_write_num_bytes macro can be replaced by a perfectly safe code which uses `n::to_xx_bytes()` to convert given number to desired representation and `buf[..N].copy_from_slice(...)` which writes that into the buffer. Closes #193
BurntSushi
pushed a commit
that referenced
this pull request
Oct 5, 2023
unsafe_write_num_bytes macro can be replaced by a perfectly safe code which uses `n::to_xx_bytes()` to convert given number to desired representation and `buf[..N].copy_from_slice(...)` which writes that into the buffer. Closes #193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsafe_write_num_bytes macro can be replaced by a perfectly safe code
which uses
n::to_xx_bytes()to convert given number to desiredrepresentation and
buf[..N].copy_from_slice(...)which writes thatinto the buffer.