Skip to content

Feature better analysis #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2021
Merged

Feature better analysis #65

merged 6 commits into from
Mar 12, 2021

Conversation

aviveiros11
Copy link
Contributor

Added a new example for running a BETTER analysis with 12 months elec and nat gas meter data.

@corymosiman12
Copy link
Contributor

I would consider calling this '...BETTER Input...', as in the future you might have a schematron on the output side. That was the intention behind the '...Pre-Simulation...', i.e. validate the contents of the file before a simulation is run.

Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested, else looks good.

Copy link
Contributor

@JieXiong9119 JieXiong9119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌭

@aviveiros11 aviveiros11 merged commit 1058fe5 into develop Mar 12, 2021
@aviveiros11 aviveiros11 deleted the feature-BETTER-analysis branch March 12, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants