Skip to content

link to python notebook as a markdown file #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022
Merged

link to python notebook as a markdown file #167

merged 2 commits into from
Apr 13, 2022

Conversation

nllong
Copy link
Member

@nllong nllong commented Apr 13, 2022

We've migrated the notebook from ipynb to a markdown, thus we need to update this link. Github views markdown files natively, so just link off to github now.

Link is the first on this page: https://buildingsync.net/technical_resources

@kflemin can you deploy after this is approved and merged? Grazie.

@nllong nllong requested review from kflemin and haneslinger April 13, 2022 17:52
@coveralls
Copy link

coveralls commented Apr 13, 2022

Pull Request Test Coverage Report for Build 2163306418

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+39.5%) to 82.715%

Totals Coverage Status
Change from base Build 1877524157: 39.5%
Covered Lines: 1828
Relevant Lines: 2210

💛 - Coveralls

@nllong
Copy link
Member Author

nllong commented Apr 13, 2022

Pull Request Test Coverage Report for Build 2162885313

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1371 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+6.0e**-05%**) to 43.239%

Files with Coverage Reduction New Missed Lines %
.tox/python/lib/python3.6/site-packages/_virtualenv.py 5 1.28%
.tox/python/lib/python3.6/site-packages/urllib3/util/ssl_match_hostname.py 10 15.49%
.tox/python/lib/python3.6/site-packages/bs4/formatter.py 13 71.93%
.tox/python/lib/python3.6/site-packages/urllib3/util/request.py 14 54.55%
.tox/python/lib/python3.6/site-packages/urllib3/connection.py 35 29.02%
.tox/python/lib/python3.6/site-packages/urllib3/poolmanager.py 65 23.44%
.tox/python/lib/python3.6/site-packages/bs4/builder/_lxml.py 78 28.16%
.tox/python/lib/python3.6/site-packages/bs4/builder/init.py 85 46.8%
.tox/python/lib/python3.6/site-packages/bs4/builder/_htmlparser.py 92 21.26%
.tox/python/lib/python3.6/site-packages/bs4/builder/_html5lib.py 111 2.65%
Totals Coverage Status
Change from base Build 1877524157: 6.0e-05%
Covered Lines: 39310
Relevant Lines: 90913

💛 - Coveralls

I'm fixing the coverage call to not include .tox results, because that ain't ours!

@kflemin
Copy link
Contributor

kflemin commented Apr 13, 2022

@nllong how do you open this md notebook in jupyter now? should there be instructions inside the md file?

@nllong
Copy link
Member Author

nllong commented Apr 13, 2022

@nllong how do you open this md notebook in jupyter now? should there be instructions inside the md file?

yes, we need to add some instructions in the markdown file! That would be on the schema site, so merging this for now.

@nllong nllong merged commit 3e1a8c6 into develop Apr 13, 2022
@nllong nllong deleted the fix-ipynb-link branch April 13, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants