Skip to content

Update BEDES Mapping #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Update BEDES Mapping #146

merged 3 commits into from
Dec 28, 2021

Conversation

haneslinger
Copy link
Contributor

No description provided.

@JieXiong9119
Copy link
Contributor

@nllong It turned out that the new version of BEDES does have duplicated List-Option (enumeration) names, so we loosed the constraint of uniqueness for querying term, 'definition, urlandrelated_term_uuid(in fact we only kept theuuidunique). Now the--save_to_db` command will not reparse but only push the mapping to db.

@@ -24,7 +24,7 @@ class BedesMapping(models.Model):
# Bedes Enumeration
class BedesEnumeration(models.Model):
content_uuid = models.CharField(max_length=100, unique=True)
term = models.CharField(max_length=100, unique=True)
term = models.CharField(max_length=100)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@haneslinger haneslinger requested a review from nllong December 28, 2021 20:34
@haneslinger haneslinger merged commit b6592ef into develop Dec 28, 2021
@haneslinger haneslinger deleted the Updated-BEDES-Mapping branch December 28, 2021 20:40
@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 1631598208

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1239 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.1%) to 43.228%

Files with Coverage Reduction New Missed Lines %
.tox/python/lib/python3.6/site-packages/charset_normalizer/models.py 10 38.97%
bsyncviewer/management/commands/bedes.py 13 95.56%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/requirements.py 13 70.13%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/_structures.py 15 55.0%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/markers.py 41 45.24%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/utils.py 47 20.9%
.tox/python/lib/python3.6/site-packages/charset_normalizer/cd.py 51 14.72%
.tox/python/lib/python3.6/site-packages/charset_normalizer/utils.py 75 29.41%
.tox/python/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/version.py 81 60.43%
.tox/python/lib/python3.6/site-packages/charset_normalizer/md.py 89 21.98%
Totals Coverage Status
Change from base Build 1478288064: -0.1%
Covered Lines: 39168
Relevant Lines: 90608

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants