-
Notifications
You must be signed in to change notification settings - Fork 615
fix: issues for angular signals api #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4733ae2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 4733ae2.
☁️ Nx Cloud last updated this comment at |
packages/core/src/__tests__/__snapshots__/angular.signals.test.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the formatting part, this PR LGTM!
# Conflicts: # packages/core/src/__tests__/__snapshots__/angular.signals.test.ts.snap # packages/core/src/generators/angular/signals/component.ts # packages/core/src/generators/angular/signals/helpers/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget we meant to approve this but forgot to! if you can go ahead and update the snapshot tests one last time, it will be merged 🙏🏽
Head branch was pushed to by a user without write access
Done :) @samijaber |
Description
Please provide the following information:
Minor fixes for Angular
api=signals
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.