Skip to content

fix: issues for angular signals api #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

nmerget
Copy link
Contributor

@nmerget nmerget commented Apr 14, 2025

Description

Please provide the following information:

Minor fixes for Angular api=signals

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@nmerget nmerget requested a review from samijaber as a code owner April 14, 2025 08:22
Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: 4733ae2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Apr 14, 2025

View your CI Pipeline Execution ↗ for commit 4733ae2.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 2m 5s View ↗
nx run-many --target test ✅ Succeeded 5m 10s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 47s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 06:20:05 UTC

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the formatting part, this PR LGTM!

# Conflicts:
#	packages/core/src/__tests__/__snapshots__/angular.signals.test.ts.snap
#	packages/core/src/generators/angular/signals/component.ts
#	packages/core/src/generators/angular/signals/helpers/index.ts
@nmerget nmerget requested a review from sidmohanty11 May 30, 2025 07:14
@samijaber samijaber enabled auto-merge (squash) June 19, 2025 12:41
Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerget we meant to approve this but forgot to! if you can go ahead and update the snapshot tests one last time, it will be merged 🙏🏽

auto-merge was automatically disabled June 25, 2025 08:12

Head branch was pushed to by a user without write access

@nmerget
Copy link
Contributor Author

nmerget commented Jun 26, 2025

@nmerget we meant to approve this but forgot to! if you can go ahead and update the snapshot tests one last time, it will be merged 🙏🏽

Done :) @samijaber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants