-
Notifications
You must be signed in to change notification settings - Fork 0
Include shadowJar artifact to release workflow #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 59 commits
ac1a325
209d23c
3cba794
7bd7b1a
396bd0e
1ccf819
ca7b8cc
450422f
58069fa
9dca6f7
085e221
89b1525
ca0e56f
1b91d55
796c993
2f891a3
96aa1e9
f88ad17
78078d0
59a58ae
61da296
74b4f83
e5f75d7
6bb3dcb
d9153c0
2e30e14
d4036d1
e5e1637
3a42837
3d2059f
f7aab46
6e3a20f
797e941
e8baf2c
8b7d2d7
6089762
be8a169
6ce9e69
28369c6
9fe8e6a
1729229
1734db8
31fd08f
a6e2324
8c61e10
64e5210
7b9c74d
1c7e422
8e13534
d6eea68
6e9c634
02f198e
03e6993
f28d5ad
5816750
17124e2
dc4ad86
4af84df
4bcbe80
db0095e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,4 +14,18 @@ standardReleasePipelineWithGenericTrigger( | |||||
mavenArtifactsPath: "$WORKSPACE/repository/", | ||||||
autoPublish: true | ||||||
) | ||||||
publishToArtifactsProdBucket( | ||||||
assumedRoleName: 'sql-jdbc-upload-role', | ||||||
source: "$WORKSPACE/artifacts.tar.gz", | ||||||
destination: "https://artifacts.opensearch.org/opensearch-clients/jdbc/opensearch-sql-jdbc-${tag}.tar.gz", | ||||||
signingPlatform: 'windows', | ||||||
sigOverwrite: true | ||||||
) | ||||||
publishToArtifactsProdBucket( | ||||||
assumedRoleName: 'sql-jdbc-shadowJar-upload-role', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. they have a separate role for shadowJars? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not actually too sure this works. I assumed that it was just a name for the jenkins job. |
||||||
source: "$WORKSPACE/build/libs/opensearch-sql-jdbc-shadow-*.jar", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but jenkins gets it from release artifacts. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ohhh I see. Thanks |
||||||
destination: "https://artifacts.opensearch.org/opensearch-clients/jdbc/opensearch-sql-jdbc-shadow-${tag}.jar", | ||||||
signingPlatform: 'windows', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
sigOverwrite: true | ||||||
) | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you have 2
publishToArtifactsProdBucket
for one jar?The second one seems more correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how it works if we specify this. As I understand artifacts.tar.gz is uploaded by default. I'm not sure if it ignores this file if
publishToArtifactsProdBucket
is called.