Made driver throw SQLSTATE 28000 for invalid username or password #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey and
acarbonetto
as code owners
acarbonetto
approved these changes
Jun 21, 2023
Yury-Fridlyand
approved these changes
Jun 22, 2023
matthewryanwells
approved these changes
Jun 22, 2023
Signed-off-by: Guian Gumpac <[email protected]>
…HTTPException Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
force-pushed
the
dev-auth-sqlstate
branch
from
35d3205 to
1282e7e
Compare
Yury-Fridlyand
approved these changes
Jun 28, 2023
Signed-off-by: Guian Gumpac <[email protected]>
forestmvey
approved these changes
Jun 29, 2023
acarbonetto
reviewed
Jun 29, 2023
| if (ex.getStatusCode() == 401) { | ||
| logAndThrowSQLException(log, new SQLException("Connection error " + ex.getMessage(), | ||
| INCORRECT_CREDENTIALS_SQLSTATE, ex)); | ||
| } else { |
There was a problem hiding this comment.
I thought we agreed this was supposed to be only in ex.getStatusCode() == 403. Alternatively, only respond with this if there's a 4XX-level error. A 5XX means something more serious happened (and the connection crashed).
There was a problem hiding this comment.
I think this should be for any attempt at connecting. https://tableau.github.io/connector-plugin-sdk/docs/drivers mentions that "Client unable to connect to server".
There was a problem hiding this comment.
Removed state "08001" as it's scope is unclear
Yury-Fridlyand
approved these changes
Jun 29, 2023
MitchellGale
approved these changes
Jun 29, 2023
Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
added a commit
that referenced
this pull request
Jun 29, 2023
* Made driver throw SQLSTATE 28000 for invalid username or password Signed-off-by: Guian Gumpac <[email protected]> * Made SQLSTATE string a constant and added a separate catch block for HTTPException Signed-off-by: Guian Gumpac <[email protected]> * Changed constant name to follow naming convention Signed-off-by: Guian Gumpac <[email protected]> * Added 08001 SQLSTATE to catch connection errors Signed-off-by: Guian Gumpac <[email protected]> * Reverted 08001 change Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
added a commit
that referenced
this pull request
Jul 10, 2023
…ensearch-project#102) * Made driver throw SQLSTATE 28000 for invalid username or password (#7) * Made driver throw SQLSTATE 28000 for invalid username or password Signed-off-by: Guian Gumpac <[email protected]> * Made SQLSTATE string a constant and added a separate catch block for HTTPException Signed-off-by: Guian Gumpac <[email protected]> * Changed constant name to follow naming convention Signed-off-by: Guian Gumpac <[email protected]> * Added 08001 SQLSTATE to catch connection errors Signed-off-by: Guian Gumpac <[email protected]> * Reverted 08001 change Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> * Added to release notes Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change throws SQLSTATE 28000 for invalid username or password which is required by Tableau. This only covers 401 responses, responses like 403 from SIGV4 returns a different message.
Before:
After:
Issues Resolved
opensearch-project#95
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.