Add support for SageMaker Inference Components in sagemaker chat #10603
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
krrishdholakia
requested changes
May 7, 2025
|
@bobbywlindsey sagemaker_chat no longer uses the openai_like/ flow. It's been migrated to our common base_llm_http_handler.py Can you please update your PR to reflect the change? You should just need to make any mods here - |
|
@krrishdholakia Nice refactor! I put my changes where you suggested and seems to work nicely 👍🏻 Could you review again? Thanks! |
|
Hey @bobbywlindsey could you please add some unit testing inside tests/litellm? |
krrishdholakia
requested changes
May 13, 2025
|
Hey @ishaan-jaff, any chance you could take a look at this PR? Thanks! |
|
@krrishdholakia I see you're the reviewer for this PR - all the checks have passed and there are no conflict with base. Can we merge? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add support for SageMaker Inference Components in sagemaker chat
Relevant issues
Fixes #9909
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
🐛 Bug Fix
Changes
If
model_idis present as a parameter forcompletion(model="sagemaker_chat/*"...)calls:model_idas the Inference Componentmodelkey and value from body of request