Updated functionality #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have found 24 endpoints from stats.nba.com that are not currently included in nba_py Here are first 6 new endpoints in 6 new classes that can hopefully be added to the master repo I'm quite new to Python and GitHub so please let me know if I'm doing anything wrong, but hopefully I did enough testing on these classes before committing.
Fixed Travis CI suggestions
Added some parameters that aren't required but can be provided anyway
Team hustle stats! Two new endpoints with their classes: TeamHustleLeaders (endpoint: leaguehustlestatsteamleaders) and TeamHustleStats (endpoint: leaguehustlestatsteam)
Player hustle stats added! 10 of 24 new endpoints now added (if you include teams.py). In this update: Two new endpoints with their classes: PlayerHustleLeaders (endpoint: leaguehustlestatsplayerleaders) and PlayerHustleStats (endpoint: leaguehustlestatsplayer)
fixed Travis CI whitespace issues and added call to _api_scrape inside TeamHustleStats
Travis CI whitespace issues fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since your branch is more recent, may we merge these branches? I'd like to extend what you've done as well.