-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Igniter install task #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
13250c8
to
5155233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is solid work! Enjoyed reviewing it.
Only comments are due to the rapid development of the USAGE guide and SimpleLocale. Propose to leave it as is for after v1.2 when the dust of Localization has settled.
lib/mix/tasks/routex.install.ex
Outdated
defp create_routex_backend(igniter, web_module) do | ||
module = Module.concat(web_module, "RoutexBackend") | ||
|
||
Igniter.Project.Module.create_module(igniter, module, """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Needs update after the default config is determined.
- Maybe we can extract the default config and use it at this place and in the USAGE guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added plug :routex
but not sure what you mean by this?
60fc234
to
5d53143
Compare
5d05a7e
to
f6548f4
Compare
CI gives this error but it passes on my machine 🤔 Not sure what's missing, is it because phoenix is not explicit in deps and is fetched through some optional one.? |
Also I'm doing some documentation for igniter currently and there by learning to use igniter better, so I'll probably have some improvements for this soon. 👍 |
We have some more to fix upfront as Inflex, dependency of Igniter, is not compatible with the upcoming Elixir. It uses regex in module attributes which is not allowed anymore.
|
efbb00b
to
e2d57f0
Compare
@BartOtten How do I reproduce this? I downloaded 1.19 and compiled igniter; it worked. 🤔 Also tried |
Using Erlang/OTP 28 RC? I think that is the major differentiator as Erlang itself seems to have switched to a new regex model. Can wait a while though, as installing Erlang 28 will be much easier once it is final. |
I couldn't get hex working on new erlang version 😅 Wojtek said
So I guess it will be fixed. 🤞 |
For learning purpose only (aka. not to rush you): https://github.com/BartOtten/routex/blob/main/.github/workflows/elixir.yml There you can see how the pipeline uses a new rebar and hex. I didn't know how to test early Erlang/Elixir releases before so I learned along the way last week :) |
#80