-
Notifications
You must be signed in to change notification settings - Fork 81
fix: fuse optimizer oom and make it stateless #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangraying
commented
Sep 22, 2021
async algorithm conflict with fused optimizer, can only support flattened inplace bucket.bagua/bagua/torch_api/algorithms/async_model_average.py Lines 84 to 89 in 2fd9eb2
This comment was generated by todo based on a
|
qadam optimizer maintain `step_id` in its statebagua/bagua/torch_api/algorithms/q_adam.py Lines 47 to 50 in 2fd9eb2
This comment was generated by todo based on a
|
This was referenced Nov 2, 2021
This was referenced Nov 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
bagua.torch_api.contrib.FusedOptimizer
is now removed and replaced bybagua.torch_api.contrib.fuse_optimizer