Lut max z #34
Lut max z #34
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @12tbuchman)
cfg/AMCL.cfg line 106 at r2 (raw file):
gen.add("publish_distances_lut", bool_t, 0, "Whether to publish the Distances Lookup Table as a point cloud for debugging.", False) gen.add("lut_max_z", double_t, 0, "Add octopmap objects to the lookup table only if they have a z height below this value.", 10.0, 0.0, 10.0)
I recommend making the max be some ridiculously large value like 100.0 (just like you have the min a ridiculously small value).
Dynamic reconfigure has become overly complex despite being unused. To simplify, remove any parameters that would require re-initializing an object to use. If these parameters need to be changed it should be done through salt.
Lowering the max z of the lookup table helps reduce the impact of drop ceilings.
There was a problem hiding this comment.
Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @bobhenz-jabil)
cfg/AMCL.cfg line 106 at r2 (raw file):
Previously, bobhenz-jabil (Bob Henz) wrote…
I recommend making the max be some ridiculously large value like 100.0 (just like you have the min a ridiculously small value).
removed from cfg file entirely
There was a problem hiding this comment.
Reviewed 6 of 6 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @12tbuchman)
This change is