adjust scrobble timing logic

[rossbates]

Using 20 seconds for maximumWaitDurationInSec creates a situation where the player will submit submission=true after only 20 seconds of play time. This creates a problem as it fires anytime the user clicks pause/next.

Setting it to 4 minutes follows the standard scrobble logic of 50% of the song duration (curPlayingSong.duration / 2) or 4 minutes for any song longer than 4 minutes.

[rossbates]

@BLeeEZ wanted to see if you had thoughts or feedback on including this change in your main branch. The change itself is trivial but the implications for how scrobbles behave is significant. While driving and listening to a large playlist on shuffle it's pretty common to listen to 20+ seconds of a song then click next.

I would just make the change in my local branch and create my own build but I have not been able to get a CarPlay entitlement (which is in itself pretty ridiculous that I can't get permission to run software I own on hardware I own)

[BLeeEZ]

Hi,
first of all thank you for getting familiar with the code and providing this PR.
Is the increased time working with short songs too (shorter than the maximumWaitDurationInSec)?

[rossbates]

@BLeeEZ the short answer is yes, this works for songs of any length. A song becomes eligible to be posted with submission=true at 50% played or 4 minutes. When testing though I found an additional issue where the scrobble timer continues to run when the song is paused. I'm going to close this and create a new branch on my end with some more significant changes.