Skip to content

6.1 Deployment #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023
Merged

6.1 Deployment #565

merged 2 commits into from
Mar 23, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 70 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving generic push and pull, based on procedures found in https://burohappold.sharepoint.com/:f:/s/BHoM/Ep--VXyQe65Kr7tFxN0hmr8B7HHqZwAW4EF_Qy5rIscsew?e=wZb2gK

Tested with BHoM_6.1.230315.beta.0

I have not tested and am not approving:

  • GBXML
  • Bluebeam
  • CSProject
  • Energyplus
  • KML

All of the above needs to be tested and approved by respective discipline owners and procedures.

@CKBoulter CKBoulter self-requested a review March 15, 2023 15:16
Copy link
Contributor

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using BHoM_6.1.230315.beta.0 and the Environment's XML_Toolkit testing procedure using the testing procedure document 0001_XML_Toolkit.

1.0 Push Test
1.3.1. passed as the .xml file is produced in the location specified and has 17566 lines. After opening XML in IES 2022 it had three stories and nine openings on the ground floor. When using Apache construction database, none are titled with 'generic' in the category but do some do begin with 'generic' in description.

generic xml testing

1.10.1 passed as the coordinates are rounded to 3 decimal places and the produced gbXML has 17360 lines. 1.12.1 and 1.14.1 pass as the 2nd line that the export reads Kelvins for TemperatureUnit, Feet for LenghtUnit, Square Feet for Area, and CubicFeet for the Volume Unit.

2.0 Pull Test
After setting true, model pulls without errors, renders in Rhino 7 and looks as previous models, and states 'Passed' in the 'Full Test Results' panel.

All panels pass in both push test and push test. Successful.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 71 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 15:25.

DETAILS:
This pull request can be merged or not merged without impact on any of its upstream dependencies..

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing by @IsakNaslundBh and @CKBoulter is valid and procedures are suitable. Happy to deploy to 6.1 beta.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 21, 2023
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

2 similar comments
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 159 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling

There are 319 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 399 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 470 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

Please be advised that the check with reference 12205989462 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 119 additional annotations waiting, made up of 0 errors and 119 warnings.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit d88d04d into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants