Skip to content

XML_Toolkit: Rename depth property from XMLDepth to Depth #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2022
Merged

XML_Toolkit: Rename depth property from XMLDepth to Depth #561

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad0f0b
Rename depth property from XMLDepth to Depth
rboulton-BH Dec 1, 2022
4e9f05f
Update depth property description and default value returned by query…
rboulton-BH Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions XML_Engine/Query/Depth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ public static double Depth(this Markup markup)

try
{
return System.Convert.ToDouble(markup.XMLDepth);
return System.Convert.ToDouble(markup.Depth);
}
catch (Exception e)
{
BH.Engine.Base.Compute.RecordError($"Could not convert XMLDepth value {markup.XMLDepth} to numerical depth.");
BH.Engine.Base.Compute.RecordError($"Could not convert XMLDepth value {markup.Depth} to numerical depth.");
return -1;
}
}
Expand Down
2 changes: 1 addition & 1 deletion XML_oM/Bluebeam/Markup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class Markup : BluebeamObject
public virtual string Label { get; set; }

[XmlElement("Depth")]
public virtual string XMLDepth { get; set; }
public virtual string Depth { get; set; }

[XmlElement("Layer")]
public virtual string Layer { get; set; }
Expand Down