Skip to content

Add pulling of Bluebeam markup schema #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 12, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Nov 11, 2021

Issues addressed by this PR

Fixes #539

Test files

See updated test procedure and associated test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Nov 11, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 11, 2021
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance
  • project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 4176736431

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 4176736831

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix copyright headers ref. 4176736431

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix project file ref. 4176736831

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 11, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

Copy link

@emilsvedjer emilsvedjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd FraserGreenroyd merged commit 536fc61 into main Nov 12, 2021
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#539-Bluebeam branch November 12, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML_Toolkit: Bluebeam markup schema handling
3 participants