Add versioning to Structural results #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakNaslundBh
added
status:do-not-merge
Making sure there is no BHoM_Guid in the properties, as that will make it impossible to deserialise. The GUID is inserted during the fallback atempt of trying to deserialise as a custom object.
adecler
reviewed
Jun 9, 2020
There was a problem hiding this comment.
Since I can only judge from the code perspective, I will leave @kThorsager to approve so only putting my review as a comment.
This looks good to me in term of following the procedure for upgrading objects.
kThorsager
previously approved these changes
Jun 9, 2020
kThorsager
approved these changes
Jun 9, 2020
|
/azp run Versioning_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
IsakNaslundBh
removed
the
status:do-not-merge
IsakNaslundBh
deleted the
Structure_oM-#783-MakeAllResultsImmutableAndAddMode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM#912
Issues addressed by this PR
Adds in
ModeNumberas a property to structural results, if not found in the initial dictionary.This is needed for the serialiser to be able to apply the correct creator map when trying to deserialise the results.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Ep9h3lEyopBBvsnP3_HGzSwBncLyPKvZnn0q6AZBwMRwzA?e=j5DdEe
Changelog
Additional comments