Skip to content

Copy builds into ProgramData instead of Roaming #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2020
Merged

Copy builds into ProgramData instead of Roaming #77

merged 4 commits into from
Jun 4, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented Jun 3, 2020

Issues addressed by this PR

BHoM/admin#5

Only changes the target of the post-build copy command. This makes it possible to test that UI_PostBuild.exe is doing its job properly.

@adecler adecler added the type:compliance Non-conforming to code guidelines label Jun 3, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone Jun 3, 2020
@adecler adecler self-assigned this Jun 3, 2020
@adecler adecler mentioned this pull request Jun 3, 2020
Merged
@adecler adecler added the status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge label Jun 3, 2020
FraserGreenroyd
FraserGreenroyd approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on workshop review, testing installer plus toolkits for building and running sample scripts

@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge label Jun 4, 2020
@IsakNaslundBh IsakNaslundBh merged commit 09ca800 into master Jun 4, 2020
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Admin-#5-Referencing branch June 4, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher

@awakeman awakeman Awaiting requested review from awakeman

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@adecler adecler

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@adecler @FraserGreenroyd @IsakNaslundBh