Skip to content

Adding versioning for Lighting results #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1391

Issues addressed by this PR

Adding custom converters for classes changed in the oM

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jun 2, 2022
@IsakNaslundBh IsakNaslundBh requested a review from enarhi June 2, 2022 14:54
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 2, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check installer
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core
  • installer
  • copyright-compliance

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 3, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 30 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 3, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 2 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit d6d3bfe into main Jun 3, 2022
@IsakNaslundBh IsakNaslundBh deleted the Lighting_oM-#1377-LightingMeshResults branch June 3, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants