Skip to content

Add support for the PostBuild to extract and copy over Dataset upgrades #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jun 1, 2022

NOTE: Depends on

Will compile without, but done in support of BHoM/BHoM_Engine#2845

Issues addressed by this PR

Enables the PostBuild to also copy across Dataset upgrades

Test files

See link in Engine PR

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jun 1, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 1, 2022
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review June 2, 2022 09:51
@FraserGreenroyd
Copy link
Contributor

@IsakNaslundBh can I confirm that this PR would not necessitate any update required to either of the wiki procedures listed on this repository? I don't think there is from what I can see, but if you could cast an eye over and double check that'd be handy.

@IsakNaslundBh
Copy link
Contributor Author

@IsakNaslundBh can I confirm that this PR would not necessitate any update required to either of the wiki procedures listed on this repository? I don't think there is from what I can see, but if you could cast an eye over and double check that'd be handy.

As it stands, without any tweaks to the verification, that is the case. Had a thought about if we want to get dataset versioning to be checked though by the Versioning verification. If we want to do that, some more tweaks to code as well as procedure is required. WOuld probably be good with a call!

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 14 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review here

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core

There are 38 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core

There are 39 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core

There are 40 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core

There are 41 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core

There are 42 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core

There are 43 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

4 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 51 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit c449b5a into main Jun 9, 2022
@IsakNaslundBh IsakNaslundBh deleted the Library_Engine-#1864-AddVersioningForLibraries branch June 9, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants