Skip to content

Add 5.1 upgrader and lock down 5.0 upgrader. Include versioning CI for 5.0 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 5, 2022
Merged

Add 5.1 upgrader and lock down 5.0 upgrader. Include versioning CI for 5.0 #183

merged 10 commits into from
Jan 5, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #182

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 17, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd FraserGreenroyd self-assigned this Jan 4, 2022
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 4, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check installer
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core
  • installer
  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning
  • installer
  • copyright-compliance

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review January 4, 2022 12:06
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4701482960

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4701482960

I am dispensating copyright-compliance as BHoMBot will be updating this automatically very soon and I want to avoid confusion with it.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2022

@FraserGreenroyd I have now provided a passing check on reference 4701482960 as requested.

@adecler
Copy link
Member

adecler commented Jan 5, 2022

The regular update looks good (once the build path was fixed) but might be worth having a quick chat on the reasons behind the changes from object to string before merging.

PS: I have updated procedure on the wiki and removed the _oM project from the list that needs an assembly file version update since that project doesn't exist anymore.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer
  • core
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4713984391

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4713984391

Per previous dispensation.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd I have now provided a passing check on reference 4713984391 as requested.

IsakNaslundBh
IsakNaslundBh approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 84 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 5a9c3a9 into main Jan 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the Versioning_Toolkit-#182-Uptick branch January 5, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@pawelbaran pawelbaran Awaiting requested review from pawelbaran

@adecler adecler Awaiting requested review from adecler

@jamesramsden-bh jamesramsden-bh Awaiting requested review from jamesramsden-bh

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade versioning to 5.1
3 participants
@FraserGreenroyd @adecler @IsakNaslundBh