-
Notifications
You must be signed in to change notification settings - Fork 3
Add Versioning for v5.0 plus versioning checks for 4.3 #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@adecler I was getting this on the local set up too, but I couldn't fathom where it's coming from? Have you seen it before? |
@FraserGreenroyd , I think this is a Custom object being produced alongside the rest. You can remove this line from the Object.json file:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
The check |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 10 requests in the queue ahead of you. |
@adecler finally got the bot to like this PR - should be good for a review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FraserGreenroyd ,
Looks good to me.
Just made a note on the list of versions to test but just something to keep in mind with no immediate action.
@@ -47,7 +47,7 @@ public static partial class Verify | |||
public static TestResult FromJsonDatasets() | |||
{ | |||
string testFolder = @"C:\ProgramData\BHoM\Datasets\TestSets\Versioning"; | |||
List<string> versions = new List<string> { "4.2", "4.1", "4.0", "3.3" }; | |||
List<string> versions = new List<string> { "4.3", "4.2", "4.1", "4.0", "3.3" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to keep that list to a minimum based on our analytics of version usage.
Happy with it staying this way for now though.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
|
Fixes #174
Built following the wiki so hopefully I didn't miss any steps! 😄