Skip to content

Add Versioning for v5.0 plus versioning checks for 4.3 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #174

Built following the wiki so hopefully I didn't miss any steps! 😄

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Sep 24, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 24, 2021
@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Sep 24, 2021

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 24, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@adecler I was getting this on the local set up too, but I couldn't fathom where it's coming from? Have you seen it before?

image

@adecler
Copy link
Member

adecler commented Sep 27, 2021

@FraserGreenroyd , I think this is a Custom object being produced alongside the rest. You can remove this line from the Object.json file:

{ "Name" : "test", "test" : "test", "BHoM_Guid" : "01778057-61d5-49e7-a8cb-61f3ae707a9a", "_bhomVersion" : "4.3 }

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Sep 27, 2021

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

There are 10 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Sep 27, 2021

@adecler finally got the bot to like this PR - should be good for a review 😄
I'm happy with the project compliance failure for now.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FraserGreenroyd ,

Looks good to me.
Just made a note on the list of versions to test but just something to keep in mind with no immediate action.

@@ -47,7 +47,7 @@ public static partial class Verify
public static TestResult FromJsonDatasets()
{
string testFolder = @"C:\ProgramData\BHoM\Datasets\TestSets\Versioning";
List<string> versions = new List<string> { "4.2", "4.1", "4.0", "3.3" };
List<string> versions = new List<string> { "4.3", "4.2", "4.1", "4.0", "3.3" };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to keep that list to a minimum based on our analytics of version usage.
Happy with it staying this way for now though.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 4d14084 into master Sep 27, 2021
@FraserGreenroyd FraserGreenroyd deleted the Versioning_Toolkikt-#174-Add50 branch September 27, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versioning 50
2 participants