-
Notifications
You must be signed in to change notification settings - Fork 1
Protection and fixes for trim with boundary and openings #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protection and fixes for trim with boundary and openings #101
Conversation
…ve constructor To save all the checks required by the create method for PLanarSurface but still ensure the endresult is an external boundary of type BoundaryCurve
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense and unit test is happy.
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
The check |
Issues addressed by this PR
Closes #100
Closes #99
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EkRElFZ1zRRPlDy90IR_DQEBv7Nr_12yZ6dN9PFOWTWnLw?e=7ZPHt5
Changelog
Additional comments