Skip to content

Protection and fixes for trim with boundary and openings #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Nov 7, 2022

Issues addressed by this PR

Closes #100
Closes #99

  • Add protection against empty lists returned from BooleanDifference
  • Make it so that PlanarSurfaces returned always has external boundaries of type BoundaryCurve (alignment across both cases when trimmed with boundary and not)
  • Update UTs

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EkRElFZ1zRRPlDy90IR_DQEBv7Nr_12yZ6dN9PFOWTWnLw?e=7ZPHt5

Changelog

Additional comments

…ve constructor

To save all the checks required by the create method for PLanarSurface but still ensure the endresult is an external boundary of type BoundaryCurve
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Nov 7, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Nov 7, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 7, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@IsakNaslundBh IsakNaslundBh changed the title TranglNet_Toolkit-Protection and fixes for trim with boundary and openings TriangleNet_Toolkit-Protection and fixes for trim with boundary and openings Nov 7, 2022
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense and unit test is happy.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 7, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd FraserGreenroyd changed the title TriangleNet_Toolkit-Protection and fixes for trim with boundary and openings Protection and fixes for trim with boundary and openings Nov 7, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 7, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

There are 12 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 7, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd merged commit 6901363 into main Nov 7, 2022
@FraserGreenroyd FraserGreenroyd deleted the TrangleNet_Toolkit-#100-ProtectionAndFixesForTrimWithBoundaryAndOpenings branch November 7, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add protection against no curves returned from BooleanDifference An error occurred on a unit test
2 participants