-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade to NetStandard #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to NetStandard #38
Conversation
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 12928361505 |
@FraserGreenroyd I have queued up your request to fix the |
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
….com/BHoM/SQL_Toolkit into SQL_Toolkit-#31-UpgradeToNetStandard
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 51 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working now.
Went through all the steps detailed in the PR description and it is all working as expected both on BHoM UI ans ZCT sides.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 28 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 36 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 33 requests in the queue ahead of you. |
Issues addressed by this PR
Fixes #31 - second attempt!
Test files
SQL_Adapter.dll
,SQL_Engine.dll
, andSQL_oM.dll
from your local assembliesdebug
mode - this should give you the same DLLs as the installerZeroCodeTool
mode - this should give you a new output folder in theSQL_Toolkit/Build
location.Net6
project, referencing the DLLs and try to pull some data replicating a script used in step 4. Providing the code compiles without compiler warnings (compiler warnings should relate to trying to use.NetFramework
in.Net
environments - these should NOT appear with this work) and data can be pulled into a console, this should be sufficient?SQL_Toolkit_Test.zip
I'm a bit kind - this zip file should help with testing steps 6 onwards - it contains a
.Net6
solution with references to the right DLLs/nugets that would come if theNetStandard
adapter was included via a nuget (the ultimate end result for this work). You will need to reference theSQL_Adapter
,SQL_Engine
, andSQL_oM
from your local build ofSQL_Toolkit/Build/netstandard2.0
folder - but the other DLLs are already hardcoded forC:/ProgramData/BHoM
so hopefully minimal set up needed!Also feel free to not use this - but it's what I made to help debug/run through my own testing instructions so figured I might as well share it! 😄
Additional comments
Other work to be included for audit as to how this approach ended up being picked:
PR #32 - original attempt to upgrade
PR #35 - fixing post build for adapter
PR #36 - reverting original attempt