-
Notifications
You must be signed in to change notification settings - Fork 2
Added override to Delete method in toolkit. #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added override to Delete method in toolkit. #275
Conversation
… of elements by id.
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enarhi @mchaf From a code perspective, I think the changes in here are fine.
They align with what is being done in https://github.com/BHoM/BHoM_Adapter/blob/583860a32c114e00e5b1f717058bbd634ed7b1ab/BHoM_Adapter/CRUD/IRead.cs#L75-L94
Long terms we need a filter with an explicit list of ObejctIds, rather than reying on the equalities, but that is out of scope for this PR.
If the functionality of the PR works, according to your testing, I am happy for this to be merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using this Test File, delete worked as expected, removing elements with matching type and objectId from the model in SAP2000.
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
… of elements by id.
Issues addressed by this PR
Closes #274
Added override to Delete method in toolkit. Thereby allowing deletion of elements by id.
Test files
Changelog
Additional comments