Skip to content

Added override to Delete method in toolkit. #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrbak
Copy link

@andrbak andrbak commented Nov 15, 2022

… of elements by id.

Issues addressed by this PR

Closes #274

Added override to Delete method in toolkit. Thereby allowing deletion of elements by id.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh requested review from mchaf and enarhi January 5, 2023 14:07
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jan 5, 2023
@IsakNaslundBh
Copy link
Contributor

sorry, @andrbak , had missed this as I do not personally have access to SAP2000. For the same reason, I am unable to test this.

@mchaf @enarhi would you be able to assist?

@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop January 5, 2023 14:31
@enarhi
Copy link
Member

enarhi commented Jan 9, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enarhi @mchaf From a code perspective, I think the changes in here are fine.

They align with what is being done in https://github.com/BHoM/BHoM_Adapter/blob/583860a32c114e00e5b1f717058bbd634ed7b1ab/BHoM_Adapter/CRUD/IRead.cs#L75-L94

Long terms we need a filter with an explicit list of ObejctIds, rather than reying on the equalities, but that is out of scope for this PR.

If the functionality of the PR works, according to your testing, I am happy for this to be merged in.

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using this Test File, delete worked as expected, removing elements with matching type and objectId from the model in SAP2000.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 5d12f2d into BHoM:develop Jan 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAP2000 should be able to be deleted by object id
4 participants