-
Notifications
You must be signed in to change notification settings - Fork 2
SAP2000: Change IAverageThickness to ITotalThickness() #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP2000: Change IAverageThickness to ITotalThickness() #261
Conversation
Updated error message- area temperature gradients are now implemented in BHoM, raise issue in SAP to support.
@BHoMBot check compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense. Not able to test, but by code inspection this should be an improvement. Code compiles to the changes made.
@JosefTaylor just to let you know, I have provided a |
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
There are 31 requests in the queue ahead of you. |
The check |
The check |
The check |
@JosefTaylor just to let you know, I have provided a |
@JosefTaylor just to let you know, I have provided a |
@JosefTaylor just to let you know, I have provided a |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
Updated error message- area temperature gradients are now implemented in BHoM, raise issue in SAP to support.
NOTE: Depends on
BHoM/BHoM_Engine#2819
Issues addressed by this PR
Average thickness is repurposed in the Structure_Engine. Instead relying on the ITotalThickness which is appropriate for a temperature gradient.
Test files
Changelog
Additional comments