Skip to content

SAP2000: Change IAverageThickness to ITotalThickness() #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Jun 9, 2022

Updated error message- area temperature gradients are now implemented in BHoM, raise issue in SAP to support.

NOTE: Depends on

BHoM/BHoM_Engine#2819

Issues addressed by this PR

Average thickness is repurposed in the Structure_Engine. Instead relying on the ITotalThickness which is appropriate for a temperature gradient.

Test files

Changelog

Additional comments

Updated error message- area temperature gradients are now implemented in BHoM, raise issue in SAP to support.
@JosefTaylor JosefTaylor requested a review from IsakNaslundBh June 9, 2022 14:45
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@JosefTaylor JosefTaylor added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jun 9, 2022
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense. Not able to test, but by code inspection this should be an improvement. Code compiles to the changes made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@JosefTaylor just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 31 requests in the queue ahead of you.

@JosefTaylor JosefTaylor changed the title Change IAverageThickness to ITotalThickness() SAP2000: Change IAverageThickness to ITotalThickness() Jun 9, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@JosefTaylor just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 10, 2022

@JosefTaylor just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 10, 2022

@JosefTaylor just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 10, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 4 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit bd19c02 into main Jun 10, 2022
@IsakNaslundBh IsakNaslundBh deleted the Structure_oM-#1386-Add-metal-deck-surface-properties branch June 10, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants