-
Notifications
You must be signed in to change notification settings - Fork 2
Add support for DifferentialTemperatureLoads #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DifferentialTemperatureLoads #242
Conversation
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
There are 79 requests in the queue ahead of you. |
@BHoMBot check installer |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming a few parts of the code - can't approve/comment on the functionality as I don't have SAP2000 installed.
@BHoMBot check compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check core |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check installer |
@JosefTaylor to confirm, the following checks are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check versioning |
@JosefTaylor to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
The check |
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
There are 17 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - changes made as requested. It does need testing before approval though (by others).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@BHoMBot check ready-to-merge |
@JosefTaylor to confirm, the following checks are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #167
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23242-DifferentialTemperatureLoad/BuroHappold_BHoM_v4.0.beta_Create%20read%20loads.gh?csf=1&web=1&e=ENijgz
Changelog
Additional comments