Skip to content

Add support for DifferentialTemperatureLoads #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 23, 2021

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Sep 14, 2021

@JosefTaylor JosefTaylor self-assigned this Sep 14, 2021
@JosefTaylor JosefTaylor added the type:feature New capability or enhancement label Sep 14, 2021
@JosefTaylor JosefTaylor marked this pull request as ready for review October 28, 2021 20:16
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 16, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 79 requests in the queue ahead of you.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • installer

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 4 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming a few parts of the code - can't approve/comment on the functionality as I don't have SAP2000 installed.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • core

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • installer

There are 2 requests in the queue ahead of you.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • versioning

There are 4 requests in the queue ahead of you.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 4 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 17 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - changes made as requested. It does need testing before approval though (by others).

Copy link

@mchaf mchaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • ready-to-merge

@JosefTaylor JosefTaylor merged commit 58f723f into main Nov 23, 2021
@JosefTaylor JosefTaylor deleted the SAP2000_Toolkit-#167-DifferentialTemperatureLoad branch November 23, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for BarDifferentialTemperatureLoad
3 participants