Skip to content

Add support for pulling new Modal results from robot #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented May 24, 2023

NOTE: Depends on

BHoM/BHoM#1521

Issues addressed by this PR

Add support for pulling of new modal results classes from Robot.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Structure_oM/%231521-AddUpdatedStructuralDynamicsResults?csf=1&web=1&e=OeKgWS

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label May 24, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this May 24, 2023
@IsakNaslundBh IsakNaslundBh requested a review from zm247 May 24, 2023 13:27
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 24, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 29 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 6 requests in the queue ahead of you.

@zm247
Copy link

zm247 commented Jun 2, 2023

Isak, PR's approved for the dynamic model extraction. Thanks for sorting this out. Hopefully we will get it on the next Beta version.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation
  • check core
  • check null-handling
  • check installer

There are 27 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zm247's review is sufficient but is not picked up by the bot due to being an extra comment so this approval is for merging purposes only. No review has been undertaken except that by @zm247

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 11d289a into develop Jun 7, 2023
@FraserGreenroyd FraserGreenroyd deleted the Structure_oM-#1471-AddUpdatedStructuralDynamicsResults branch June 7, 2023 18:43
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants