Skip to content

Robot_Toolkit: Handle tags as groups in robot #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 22, 2023
Merged

Robot_Toolkit: Handle tags as groups in robot #508

merged 18 commits into from
Feb 22, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #507

Update tag management in Robot, relating them to the groups. System changed so that:

  • Cached tags are cleared at start and end of each Push/Pull
  • At first request of tags of a particular type, they are populated based on corresponding group in Robot
  • At end of each push, groups are updated in Robot based on the cached tags

Test files

Similarly to what was done in BHoM/BHoM_Adapter#332 .

This contains multiple cases of testing through this functionality.

Additionally, any scripts like https://burohappold.sharepoint.com/:f:/r/sites/BHoM/Installers/Scripts/Burohappold_BHoM_v5.3/Structures%20-%20Create%20-%20Read%20-%20Update%20-%20Elements?csf=1&web=1&e=fawkv8 should still function as intended.

Changelog

Additional comments

@IsakNaslundBh
Add override for FilterRequest, making it so that if a tag is present…
568fb77 
…, objects from that Category and group name corresponding to the tag is pulled
@IsakNaslundBh
Adding methods for getting tags out and in based on groups
eb7a2ff
@IsakNaslundBh
Make cached taggs be pulled based on Groups in Robot and add method t…
006a949 
…o clear tags
@IsakNaslundBh
Change default return Type for group type to Undefined
aab2d43
@IsakNaslundBh
Make Pull and Push clear the tags, and have push apply the tags as gr…
32d994b 
…oups in Robot
@IsakNaslundBh
Minor tweak to read, getting the first item out from the collection o…
c228110 
…nce, instead of multiple calls to `First()`
@IsakNaslundBh
Add new collection storing all preexisting groups
7164d45 
Doing so to be able to cull out any groups that do not longer have any items in them
@IsakNaslundBh
Add support for Panel tags
9f6ca43
@IsakNaslundBh
Fix using the correct type when finding groups with a particular type…
ae0869b 
… name for FilterRequest
@IsakNaslundBh
Adding verification solution and project to repo
69d5bc2
@IsakNaslundBh
Adding push tests for new tag functionality
f80fd84
@IsakNaslundBh
Adding pull tests and test model
de8dc21
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Feb 6, 2023
@IsakNaslundBh IsakNaslundBh requested a review from alelom February 6, 2023 10:21
@IsakNaslundBh IsakNaslundBh self-assigned this Feb 6, 2023
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 125 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 133 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 140 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 148 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 156 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 164 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 171 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

alelom
alelom previously approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the Unit Tests provided and the Elements gh script. Useful discussion around testing recorded thanks to this PR!

@alelom
Copy link
Member

alelom commented Feb 17, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@IsakNaslundBh IsakNaslundBh requested a review from alelom February 20, 2023 13:16
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

alelom
alelom approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving new changes.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2023

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11488681137

@IsakNaslundBh
Copy link
Contributor Author

Will dispensate this. Has been approved to do so by @FraserGreenroyd offline:
image

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11488681137

1 similar comment
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11488681137

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 22, 2023

@IsakNaslundBh I have now provided a passing check on reference 11488681137 as requested.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 22, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit b18343f into develop Feb 22, 2023
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#507-HandleTagsAsGroupsInRobot branch February 22, 2023 11:10
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle tags as groups in Robot
3 participants
@IsakNaslundBh @alelom @FraserGreenroyd