Skip to content

Add load dependencies on Dependency Types #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Jan 24, 2023

Issues addressed by this PR

Closes #505

Test files

Changelog

Additional comments

@alelom alelom requested a review from IsakNaslundBh January 24, 2023 15:30
@alelom alelom self-assigned this Jan 24, 2023
@alelom alelom added type:feature New capability or enhancement size:XS Measured in seconds labels Jan 24, 2023
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 1, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 1, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 1, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 1, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh IsakNaslundBh added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Feb 1, 2023
@IsakNaslundBh
Copy link
Contributor

IsakNaslundBh commented Feb 1, 2023

Found an issue on the base adapter regarding dependencies that needs to be handled before this is merged.

Putting a Do-not merge tag on this PR until resolved.

Issue raised here: BHoM/BHoM_Adapter#339

Apart from that I am generally happy with this PR.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Working well together with BHoM/BHoM_Adapter#340

Will hold of merging until the PR on the BHoM_Adapter has been approved and merged

@IsakNaslundBh IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Feb 3, 2023
@IsakNaslundBh
Copy link
Contributor

Now, with the Adapter PR merged, happy for this to go in

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 58becdf into develop Feb 3, 2023
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#505-addLoadDependencies branch February 3, 2023 07:02
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS Measured in seconds type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add load dependencies on Dependency Types
2 participants