-
Notifications
You must be signed in to change notification settings - Fork 4
Add load dependencies on Dependency Types #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
Found an issue on the base adapter regarding dependencies that needs to be handled before this is merged. Putting a Do-not merge tag on this PR until resolved. Issue raised here: BHoM/BHoM_Adapter#339 Apart from that I am generally happy with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Working well together with BHoM/BHoM_Adapter#340
Will hold of merging until the PR on the BHoM_Adapter has been approved and merged
Now, with the Adapter PR merged, happy for this to go in |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #505
Test files
Changelog
Additional comments