Skip to content

Fixing issues with filtering meshes by ID #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Dec 9, 2021

Issues addressed by this PR

Closes #475

Fixing issues filtering meshes by Ids. This is done to fix a bug making it now possible to properly filter out MeshResults

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Eo7ARTMF0vpIlM15UzkhF2UBah559sZNdWmLRL6KHFCjGw?e=hLuRmS

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh requested a review from alelom December 9, 2021 15:41
@IsakNaslundBh IsakNaslundBh self-assigned this Dec 9, 2021
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Dec 9, 2021
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot project compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 9, 2021

@IsakNaslundBh sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@IsakNaslundBh IsakNaslundBh requested a review from Droidx1 December 9, 2021 15:51
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 9, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • project-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 9, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 9, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 10, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • installer

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. LGTM.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 9 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • versioning
  • ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit a0d8283 into main Dec 14, 2021
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#475-FixIssuesWithFIlterFEMeshAndMeshResultRead branch December 14, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem filtering meshresult with object ids
2 participants