Skip to content

Update namespace for some engine methods #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2020
Merged

Update namespace for some engine methods #380

merged 3 commits into from
Jun 2, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #379

Make sure all engine methods and oM are in the correct namespace.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EkRSNifmDk5HtESlqw1l3mUBGWp5gHR8V_zEsDxYc2pQuQ?e=kMovOe

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Jun 2, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone Jun 2, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 2, 2020
@kThorsager
Copy link
Contributor

kThorsager commented Jun 2, 2020 •
edited
Loading

Is the LoadingPanelPropertyComparer exempt as it's an object?

@IsakNaslundBh
Copy link
Contributor Author

Is the LoadingPanelPropertyComparer exempt as it's an object?

Thanks, will fix as well.

@IsakNaslundBh IsakNaslundBh merged commit 32554a4 into master Jun 2, 2020
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#379-UpdateNamespace branch June 2, 2020 13:38
@alelom alelom mentioned this pull request Jun 3, 2020
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kThorsager kThorsager kThorsager approved these changes

@Martian42 Martian42 Awaiting requested review from Martian42

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Robot_Toolkit: Change namespace of oM and Engine
2 participants
@IsakNaslundBh @kThorsager