-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for ToRhino for NurbsCurve for Rhino7 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ToRhino for NurbsCurve for Rhino7 #232
Conversation
Changing it so that version is checked and version5 convert is called if version is 5. For versions above 5 the same methodology is used and is instead put in the main method. ToRhino6 method remove and versioned to the main method.
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor code formatting changes.
Otherwise looks good on code review - code has moved from the deleted file to the ToRhino
file which I think it clean and I like the implementation.
As the suggestions are minor and are for formatting @IsakNaslundBh I'm not going to wait for you to commit them - I'll do them now and trigger all the bot checks, then leave you to merge - if you're unhappy with my suggestions that I commit you can then change them before merge - hopefully you don't mind doing it this way, but as I suspect you'll be happy, I figure this is the quickest way to allow a merge so we can unblock the R7 roll out we were discussing 😄
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
Happy with the changes @FraserGreenroyd . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have remembered to do this bit last night...
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #215
Changing it so that version is checked and version5 convert is called if version is 5. For versions above 5 the same methodology is used and is instead put in the main method. ToRhino6 method remove and versioned to the main method.
Test files
Changelog
Additional comments