Skip to content

Adding ToRhino method for Texture #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1389

Issues addressed by this PR

Adding ToRhino method for Texture, returning a rhino DisplayMaterial

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label May 13, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this May 13, 2022
michaelhoehn
michaelhoehn previously approved these changes May 25, 2022
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and approved this feature. LGTM!

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 154 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 167 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • core
  • null-handling
  • serialisation

There are 147 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 155 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, versioning, project-compliance, code-compliance, documentation-compliance, serialisation, null-handling, copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous review from @michaelhoehn . Commits since that review have been 1 compliance, and 1 typo fixed in discussion with @IsakNaslundBh . Checks have been given neutral status as they passed on the commit prior to the typo fix which was the only change.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 146 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6623389143

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6623389143

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@FraserGreenroyd I have now provided a passing check on reference 6623389143 as requested.

@IsakNaslundBh IsakNaslundBh merged commit 65c2039 into main May 27, 2022
@IsakNaslundBh IsakNaslundBh deleted the Graphics_oM-#485-AddGraphsicsRenderTexture branch May 27, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants