-
Notifications
You must be signed in to change notification settings - Fork 3
Adding ToRhino method for Texture #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ToRhino method for Texture #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and approved this feature. LGTM!
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 154 requests in the queue ahead of you. |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 167 requests in the queue ahead of you. |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 147 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 155 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, versioning, project-compliance, code-compliance, documentation-compliance, serialisation, null-handling, copyright-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on previous review from @michaelhoehn . Commits since that review have been 1 compliance, and 1 typo fixed in discussion with @IsakNaslundBh . Checks have been given neutral status as they passed on the commit prior to the typo fix which was the only change.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 146 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6623389143 |
@FraserGreenroyd I have now provided a passing check on reference |
NOTE: Depends on
BHoM/BHoM#1389
Issues addressed by this PR
Adding ToRhino method for Texture, returning a rhino DisplayMaterial
Test files
Changelog
Additional comments