Skip to content

Align to Graphics_oM Vertex to RenderPoint refactoring #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Aug 27, 2021

NOTE: Depends on

BHoM/BHoM_Engine#2606

Issues addressed by this PR

Closes #210

Test files

Changelog

Additional comments

@alelom alelom requested a review from enarhi August 27, 2021 13:39
@alelom alelom self-assigned this Aug 27, 2021
@alelom alelom requested a review from al-fisher August 27, 2021 13:39
@alelom alelom added the type:compliance Non-conforming to code guidelines label Aug 27, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 27, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 27, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 27, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

2 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 27, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 27, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on Revit_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@alelom
Copy link
Member Author

alelom commented Sep 17, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 14 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@alelom
Copy link
Member Author

alelom commented Sep 17, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

Please be advised that the check with reference 3634335343 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 31 additional annotations waiting, made up of 0 errors and 31 warnings.

@alelom
Copy link
Member Author

alelom commented Sep 17, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 25 requests in the queue ahead of you.

@alelom
Copy link
Member Author

alelom commented Sep 17, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 17, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 56 requests in the queue ahead of you.

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on TriangleNet_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on TriangleNet_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 80 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd FraserGreenroyd merged commit 89c83c9 into main Sep 29, 2021
@FraserGreenroyd FraserGreenroyd deleted the Graphics_oM-#1273-RenderPoint branch September 29, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align to Graphics_oM Vertex to RenderPoint refactoring
3 participants