Skip to content

LinkedElementsInView - view type check added #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1580

Added view type check to Query.LinkedElementsInView to avoid crashing error when calling method on a drafting view.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki self-assigned this Jun 24, 2025
@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Jun 24, 2025
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve

@pawelbaran
Copy link
Member

@BHoMBot check compliance
@BHoMBot check core

Copy link

bhombot-ci bot commented Jun 24, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

There are 9 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Jun 24, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling
  • check versioning
  • check installer

There are 6 requests in the queue ahead of you.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 24, 2025

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

There are 3 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit e73bac2 into develop Jun 24, 2025
12 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1580-LinkedElementsInView-ViewTypeFix branch June 24, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkedElementsInView - drafting view crashing bug
2 participants