Skip to content

Support for disjoint profiles added #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Support for disjoint profiles added #1549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 38 additions & 60 deletions Revit_Core_Engine/Convert/Structure/FromRevit/Profile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ private static FreeFormProfile FreeFormProfileFromRevit(this FamilySymbol family
}

// Check if one and only one solid exists to make sure that the column is a single piece
Solid solid = null;
List<Solid> solids = null;
Options options = new Options();
options.DetailLevel = ViewDetailLevel.Fine;
options.IncludeNonVisibleObjects = false;
Expand All @@ -722,9 +722,9 @@ private static FreeFormProfile FreeFormProfileFromRevit(this FamilySymbol family

familySymbol.Activate();
doc.Regenerate();
solid = familySymbol.get_Geometry(options).SingleSolid();
if (solid != null)
solid = SolidUtils.Clone(solid);
solids = familySymbol.Solids(options);
if (solids != null)
solids = solids.Select(x => SolidUtils.Clone(x)).ToList();

tempTransaction.RollBack();
}
Expand All @@ -737,62 +737,66 @@ private static FreeFormProfile FreeFormProfileFromRevit(this FamilySymbol family

familySymbol.Activate();
doc.Regenerate();
solid = familySymbol.get_Geometry(options).SingleSolid();
if (solid != null)
solid = SolidUtils.Clone(solid);
solids = familySymbol.Solids(options);
if (solids != null)
solids = solids.Select(x => SolidUtils.Clone(x)).ToList();

tempTransaction.RollBack();
}
}
}
else
solid = familySymbol.get_Geometry(options).SingleSolid();
solids = familySymbol.Solids(options);

if (solid == null)
solids = solids?.Where(x => x.SurfaceArea > Tolerance.Distance).ToList();
if (solids == null || solids.Count == 0)
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be found because it is empty or it consists of more than one solid. ElementId: " + familySymbol.Id.IntegerValue.ToString());
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be found because it is empty. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
}

Autodesk.Revit.DB.Face face = null;
foreach (Autodesk.Revit.DB.Face f in solid.Faces)
List<ICurve> profileCurves = new List<ICurve>();
foreach (Solid solid in solids)
{
if (f is PlanarFace && (f as PlanarFace).FaceNormal.Normalize().IsAlmostEqualTo(-direction, 0.001))
Autodesk.Revit.DB.Face face = null;
foreach (Autodesk.Revit.DB.Face f in solid.Faces)
{
if (face == null)
face = f;
else
if (f is PlanarFace && (f as PlanarFace).FaceNormal.Normalize().IsAlmostEqualTo(-direction, 0.001))
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be found. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
if (face == null)
face = f;
else
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be found. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
}
}
}
}

if (face == null)
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be found. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
}
if (face == null)
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be found. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
}

List<ICurve> profileCurves = new List<ICurve>();
foreach (EdgeArray curveArray in (face as PlanarFace).EdgeLoops)
{
foreach (Edge c in curveArray)
foreach (EdgeArray curveArray in (face as PlanarFace).EdgeLoops)
{
ICurve curve = c.AsCurve().IFromRevit();
if (curve == null)
foreach (Edge c in curveArray)
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be converted due to curve conversion issues. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
ICurve curve = c.AsCurve().IFromRevit();
if (curve == null)
{
BH.Engine.Base.Compute.RecordWarning("The profile of a family type could not be converted due to curve conversion issues. ElementId: " + familySymbol.Id.IntegerValue.ToString());
return null;
}
profileCurves.Add(curve);
}
profileCurves.Add(curve);
}
}

if (profileCurves.Count != 0)
{
BH.oM.Geometry.Point centroid = solid.ComputeCentroid().PointFromRevit();
BH.oM.Geometry.Point centroid = (solids.Select(x => x.ComputeCentroid() * x.Volume).Aggregate((x, y) => x + y) / solids.Sum(x => x.Volume)).PointFromRevit();
Vector tan = direction.VectorFromRevit().Normalise();

// Adjustment of the origin to global (0,0,0).
Expand Down Expand Up @@ -822,32 +826,6 @@ private static FreeFormProfile FreeFormProfileFromRevit(this FamilySymbol family

/***************************************************/

[Description("Queries a single solid from the Revit GeometryElement. If there is more than one solid inside the GeometryElement, null is returned.")]
[Input("geometryElement", "Revit GeometryElement to be queried.")]
[Output("solid", "Single solid from the input Revit GeometryElement. If there is more than one solid inside the GeometryElement, null is returned.")]
private static Solid SingleSolid(this GeometryElement geometryElement)
{
Solid solid = null;
foreach (GeometryObject obj in geometryElement)
{
if (obj is Solid)
{
Solid s = obj as Solid;
if (!s.Faces.IsEmpty)
{
if (solid != null)
return null;

solid = s;
}
}
}

return solid;
}

/***************************************************/

private static BH.oM.Geometry.Line MullionLine(this Mullion mullion)
{
Curve curve = mullion?.LocationCurve;
Expand Down