-
Notifications
You must be signed in to change notification settings - Fork 15
Enum reflecting Revit categories added and category matching mechanism refactored #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, also the UI of the enums has been tweaked in BHoM/BHoM_UI#448 @travispotterBH |
I have just pushed a surgical commit that is probably easiest to review in isolation - it is only removal of redundant method parameters, so you should only see minor removals, no other changes. |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check null-handling |
@pawelbaran to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
@BHoMBot check versioning |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
The check |
I've gone through the code and all looks good. Having an issue with obtaining a Rhino license on my laptop though, so will test this in Grasshopper as soon as IT sorts Rhino out for me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review @vietle-bh, on your comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #1226
Closes #1295
Test files
On SharePoint - open your fav model and try pulling by category chosen from dropdown. Dropdown UX improvement has been proposed in BHoM/Grasshopper_UI#677 and BHoM/BHoM_UI#450.
Changelog
BH.oM.Revit.Enums.Category
added with all Revit categories along with human-readable labels in attributesBH.Revit.Engine.Core.Query.BuiltInCategory(string, bool)
CategoriesWithNames
method added that returns a collection of built in categories with correspondent labels that are consistently supported by the systemAdditional comments
Now we should be able to freely extend the list of supported categories @travispotterBH - for now I added
Revision
from the nonstandard ones.