-
Notifications
You must be signed in to change notification settings - Fork 15
Add BHoM Information Version Button and Update Website Links #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BHoM Information Version Button and Update Website Links #1310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the update to existing buttons to make use of the information coming through. A minor compliance fix but otherwise I'd be happy from my perspective if someone from the Revit side can do a quick look/test functionality wise.
Co-authored-by: Fraser Greenroyd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in different Revit versions and it works without issues 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Viet Le <[email protected]>
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check required |
@travispotterBH to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
The check |
The check |
The check |
@travispotterBH fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
1 similar comment
@travispotterBH fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot check core |
@travispotterBH to confirm, the following actions are now queued:
|
@BHoMBot check core |
@travispotterBH to confirm, the following actions are now queued:
There are 28 requests in the queue ahead of you. |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy that this code now fulfils the requirements laid out by the issue and checks are happy.
FAO: @FraserGreenroyd The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10972986667 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on BHoM/BHoM_UI#446
Issues addressed by this PR
Closes #1296
Test files
Changelog
Additional comments