-
Notifications
You must be signed in to change notification settings - Fork 15
Added owner to Checkout Status methods #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added owner to Checkout Status methods #1292
Conversation
I don't agree with modifying the signatures here to include the out variable in this way. I suggest we go with method overloading here. Only modifying the signature causes this cascade of changes to methods in this toolkit and in their implementations across the other toolkit. This also requires the developer who is choosing to implement this to then have to instantiate a new variable that may be unused. So if we just create additional methods with an extended signature we can have best of both -- availability of the information, and only when required. I recognize this increase LOC but in this case I think it worthwhile. |
This reverts commit 8bb692c.
@travispotterBH, I fully agree and changed the methods according to your suggestions. Also added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking up my comments. Happy to approve.
@BHoMBot check compliance |
@BHoMBot check required |
@BHoMBot check beta-required |
The base branch was changed.
@BHoMBot check compliance |
@michal-pekacki to confirm, the following actions are now queued:
There are 137 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after code checking and testing it through the dependent PR.
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #
Added owner
out
parameter toCheckout Status
methods.Test files
Changelog
Additional comments