Skip to content

Added owner to Checkout Status methods #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #

Added owner out parameter to Checkout Status methods.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Dec 15, 2022
@michal-pekacki michal-pekacki self-assigned this Dec 15, 2022
@travispotterBH
Copy link

I don't agree with modifying the signatures here to include the out variable in this way. I suggest we go with method overloading here. Only modifying the signature causes this cascade of changes to methods in this toolkit and in their implementations across the other toolkit. This also requires the developer who is choosing to implement this to then have to instantiate a new variable that may be unused. So if we just create additional methods with an extended signature we can have best of both -- availability of the information, and only when required. I recognize this increase LOC but in this case I think it worthwhile.

@travispotterBH
Copy link

Also, if we are going to use the out parameter here for the owner, if the owner is empty I believe we should be doing this check here and not sending out null, rather sending out "unknown" or something similar, lest we end up with something like this:
image

@michal-pekacki
Copy link
Contributor Author

michal-pekacki commented Dec 16, 2022

@travispotterBH, I fully agree and changed the methods according to your suggestions. Also added IsWorkshared check 👍

travispotterBH
travispotterBH previously approved these changes Dec 16, 2022
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up my comments. Happy to approve.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

@travispotterBH
Copy link

@BHoMBot check required

@travispotterBH
Copy link

@BHoMBot check beta-required

@michal-pekacki michal-pekacki changed the base branch from main to develop January 3, 2023 10:37
@michal-pekacki michal-pekacki dismissed travispotterBH’s stale review January 3, 2023 10:37

The base branch was changed.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 3, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 137 requests in the queue ahead of you.

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after code checking and testing it through the dependent PR.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 27 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 07f0a94 into develop Jan 4, 2023
@FraserGreenroyd FraserGreenroyd deleted the Revit_Tools-#661-FireAccessoryProgressBar branch January 4, 2023 11:19
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants