RevitComparisonConfig.NumericTolerance overridden

[pawelbaran]

Issues addressed by this PR

Closes #1199

Test files

Invoke the RevitDiffing tests in DiffingTests_Prototypes . They should all pass.

Changelog

• The default NumericalTolerance for RevitDiffing is now set to 1e-6 instead of Double.MaxValue. This will affect every Diffing done with RevitDiffing from now on. Comparisons on the same sets of objects done previously with RevitDiffing will return different results after this PR, if the default tolerance of was used. To replicate the same results as before, set Double.MaxValue manually on the NumericTolerance property of the RevitComparisonConfig before triggering the RevitDiffing.

Additional comments

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

There are 9 requests in the queue ahead of you.

[bhombot-ci]

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

[bhombot-ci]

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

[alelom]

This PR was tested with the DiffingTests_Prototypes toolkit. No errors were reported by it.

All scripts are bound to keep working as before, with the exception that the results returned by the RevitDiffing (on the same couples of input object sets) may be different because of this PR.

This approach is the preferred one when modifying default values for ComparisonConfigs (and finally a good use case for virtual/override)! 😄

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• copyright-compliance
• dataset-compliance

[pawelbaran]

@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• ready-to-merge

There are 7 requests in the queue ahead of you.

[bhombot-ci]

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6225050990

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6225050990

[bhombot-ci]

@FraserGreenroyd I have now provided a passing check on reference 6225050990 as requested.