Skip to content

Revit_Core_Engine: Add Color convert Rebased #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Apr 11, 2022

This is a rebase of #1185 - comparison with the original PR available here

Issues addressed by this PR

Closes #1184

Color convert added, from System.Drawing to Revit API and vice-versa.

Test files

N/A

Changelog

Added BH.Revit.Engine.Core.Convert.Color.ToRevit
Added BH.Revit.Engine.Core.Convert.Color.FromRevit

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Apr 11, 2022
@pawelbaran pawelbaran self-assigned this Apr 11, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 11, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 9 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 11, 2022

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5977170319

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5977170319

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 11, 2022

@FraserGreenroyd I have now provided a passing check on reference 5977170319 as requested.

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on various Revit models and versions and works as successfully as before! 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2022

@pawelbaran to confirm, the following checks are now queued:

  • dataset-compliance
  • copyright-compliance
  • ready-to-merge

There are 5 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2022

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6009534226

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6009534226

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2022

@FraserGreenroyd I have now provided a passing check on reference 6009534226 as requested.

@pawelbaran pawelbaran merged commit 73fef10 into main Apr 13, 2022
@pawelbaran pawelbaran deleted the Revit_Schematic_Engine-#438-RebasedAddSymbolChecks branch April 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to convert to System.Drawing color to Revit color
3 participants