Skip to content

Tweak of StringValue method to return actual string as shown by Revit #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2022
Merged

Tweak of StringValue method to return actual string as shown by Revit #1180

merged 1 commit into from
Apr 1, 2022

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #

Test files

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 30, 2022
@pawelbaran pawelbaran self-assigned this Mar 30, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling

1 similar comment
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 30, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • core
  • null-handling

@pawelbaran
Copy link
Member Author

@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 30, 2022

@pawelbaran to confirm, the following checks are now queued:

  • serialisation
  • versioning
  • installer

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 30, 2022

@pawelbaran to confirm, the following checks are now queued:

  • installer

There are 3 requests in the queue ahead of you.

tiagogrossi
tiagogrossi previously approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@tiagogrossi tiagogrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is working in linked PR, nice code modifications.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 13 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 37 requests in the queue ahead of you.

michal-pekacki
michal-pekacki previously approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 35 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 14 requests in the queue ahead of you.

@pawelbaran pawelbaran dismissed stale reviews from michal-pekacki and tiagogrossi via 618fc36 April 1, 2022 15:06
@pawelbaran pawelbaran force-pushed the Utility_Engine-#408-AddSelectItemsFromListREBASE branch from e854315 to 618fc36 Compare April 1, 2022 15:06
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@pawelbaran
Copy link
Member Author

@BHoMBot check core

1 similar comment
@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • core

@pawelbaran
Copy link
Member Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • dataset-compliance
  • copyright-compliance

tiagogrossi
tiagogrossi approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@tiagogrossi tiagogrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 2 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • core

There are 3 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • null-handling
  • serialisation
  • versioning
  • dataset-compliance
  • ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2022

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran pawelbaran merged commit 3e63d9a into main Apr 1, 2022
@pawelbaran pawelbaran deleted the Utility_Engine-#408-AddSelectItemsFromListREBASE branch April 1, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagogrossi tiagogrossi tiagogrossi approved these changes

@michal-pekacki michal-pekacki michal-pekacki left review comments

Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelbaran @tiagogrossi @michal-pekacki