Handling of host information refined, support for FamilyInstances hosted on linked elements plus ToRevit convert for Architecture.BuildersWork.Opening added #1127
Conversation
…be available for both convert and update
…tId on RevitHostFragment changed to string LinkDocument, code aligned to work with the changes
|
@BHoMBot check serialisation |
|
@FraserGreenroyd to confirm, the following checks are now queued:
|
|
@BHoMBot check null-handling |
|
@pawelbaran to confirm, the following checks are now queued:
|
|
@FraserGreenroyd what is the chance the null-handling check is simply wrong? Or could we make it at least return an informative message? I was scrolling through the entire chain of PRs a few times and feel like another hour can be used more efficiently than doing this yet another time... |
|
@BHoMBot check null-handling |
|
@FraserGreenroyd to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
|
@BHoMBot check required |
|
@pawelbaran to confirm, the following checks are now queued:
|
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with:
|
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
|
@BHoMBot check null-handling |
|
@FraserGreenroyd to confirm, the following checks are now queued:
|
|
@pawelbaran just to let you know, I have provided a |
|
@pawelbaran just to let you know, I have provided a |
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with:
|
|
@pawelbaran to confirm, the following checks are now queued:
There are 3 requests in the queue ahead of you. |
|
@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4358521994 |
|
@FraserGreenroyd I have now provided a passing check on reference |
|
@BHoMBot check ready-to-merge |
|
@FraserGreenroyd to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
NOTE: Depends on
BHoM/BHoM_Engine#2705
BHoM/Versioning_Toolkit#179
Issues addressed by this PR
Closes #990
Closes #1012
Test files
PR-specific tests on SharePoint:
PullPushandPullPushandPullThe above tests are meant to become the new versions of standard Alpha test files. Additionally PerformanceTest verifies the execution speed of geometrical search, which seems to be quite satisfying.
On top of the above, verifying UpdateType from the standard test library is recommended.
Changelog
ToRevitconvert method forBH.oM.Architecture.BuildersWork.OpeningaddedRevitHostFragmentintroduced to consistently store the information about host Id as well as its original document in case when it is a linkRevitIdentifiersrefined to reflect the changes in handling of host/link informationFindHostandContainingElementmethods added to enable geometrical search for host elementsCreate.FamilyInstancerefined to accept host elements from linked modelsModify.SetLocationrefined to support host elements from linked modelsLinkInstancequeries refined to support the above changesHostIdquery replaced withHostInformationto return both Id and document infoSetTypemethod cleaned upAdditional comments
This is a massive PR, but was hard to split into smaller ones taken the mutual relationships between most changes - I will provide as many tests as possible to ease the pain of the reviewers.
There is one breaking change -
HostIdproperty has been removed fromRevitIdentifiersfragment and moved toRevitHostFragment, but the values are not going to be copied over - this is because this would require versioning of allIBHoMObjects, which I guess would be super heavy.@kayleighhoude @enarhi, among the test files there is a sample showing workflow with parameter and family mapping, which allows for pulling elements of wide categories (e.g. Generic Models or Mechanical Equipment) and mapping them to particular BHoM types incl. transfer of parameters to properties - I believe this is going to be neat!
@ssiimmoonnee the concept of host search could be helpful in e.g. finding hosts for windows/doors - happy to pick this up in the next PRs!