Skip to content

Update Revit_Engine.csproj to include RevitDiffing.cs #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 14, 2021

Issues addressed by this PR

Closes #1107

Test files

See #1106

Changelog

Additional comments

@alelom alelom self-assigned this Oct 14, 2021
@alelom alelom added type:bug Error or unexpected behaviour size:XS Measured in seconds labels Oct 14, 2021
@alelom
Copy link
Member Author

alelom commented Oct 14, 2021

@BHoMBot check-required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2021

@alelom sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@alelom
Copy link
Member Author

alelom commented Oct 14, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@alelom
Copy link
Member Author

alelom commented Oct 14, 2021

@BHoMBot check ready-to-merge
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2021

@alelom to confirm, the following checks are now queued:

  • ready-to-merge
  • dataset-compliance
  • copyright-compliance

There are 10 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2021

FAO: @FraserGreenroyd
@alelom is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 3892590561

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 3892590561

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2021

@FraserGreenroyd I have now provided a passing check on reference 3892590561 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 9d5963c into main Oct 14, 2021
@FraserGreenroyd FraserGreenroyd deleted the Revit_Engine-#1107-updateCsproj branch October 14, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS Measured in seconds type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing to include RevitDiffing.cs in Revit_Engine.csproj
3 participants