Skip to content

Remove reference and usings pointing to Common_oM and update namespace #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2020
Merged

Remove reference and usings pointing to Common_oM and update namespace #86

merged 2 commits into from
Jun 3, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jun 1, 2020 •
edited
Loading

Issues addressed by this PR

Closes #85
Closes #87

  • Remove reference and and usings pointing to the to-be-removed common_oM
  • Change namespace of oM and Engine to include Adapters

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Etymz_3Y6etFr47o9037B_IBHgLoGeX9aJ-ks6krVFw__w?e=PP8frp

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Jun 1, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone Jun 1, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 1, 2020
@IsakNaslundBh IsakNaslundBh changed the title Remove reference and usings pointing to Common_oM Remove reference and usings pointing to Common_oM and update namespace Jun 1, 2020
MartinHenriksen
MartinHenriksen approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@MartinHenriksen MartinHenriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MartinHenriksen
Copy link
Contributor

/azp run RFEM_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MartinHenriksen MartinHenriksen merged commit ba2d54a into master Jun 3, 2020
@MartinHenriksen MartinHenriksen deleted the RFEM_Toolkit-#85-RemoveReferenceToCommon_oM branch June 3, 2020 13:25
@alelom alelom mentioned this pull request Jun 3, 2020
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHenriksen MartinHenriksen MartinHenriksen approved these changes

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

RFEM_Toolkit: Change namespace of oM and Engine RFEM_Toolkit: Remove reference to common_oM
2 participants
@IsakNaslundBh @MartinHenriksen