Skip to content

Enabled installation of Referenced VirtualEnv handling nulls #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Mar 16, 2023

Issues addressed by this PR

Closes #97

Test files

Changelog

Additional comments

@tg359 tg359 requested a review from jamesramsden-bh March 16, 2023 11:48
@tg359 tg359 self-assigned this Mar 16, 2023
@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against Python TK and Ladybug_Tools TK test scripts, both returned a pass.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 15 requests in the queue ahead of you.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance

There are 8 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh added the type:bug Error or unexpected behaviour label Mar 17, 2023
@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 581ad02 into develop Mar 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#97-FixExistingEnvironmentQuery branch March 18, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query of existing environments returning null and not generating directory for downstream use
3 participants