Skip to content

6.1 Deployment #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 23, 2023
Merged

6.1 Deployment #45

merged 5 commits into from
Mar 23, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd FraserGreenroyd self-requested a review March 13, 2023 18:11
@FraserGreenroyd
Copy link

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 23 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 13, 2023
jamesramsden-bh
jamesramsden-bh previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested BHoM_6.1.230315.beta.0.msi against the Pyschrometrics testing procedure. The procedure produced a pass result.

sherminmcclernon
sherminmcclernon reviewed Mar 15, 2023
View reviewed changes
Copy link

@sherminmcclernon sherminmcclernon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed testing procedure and all components returned successful result. 230315 beta tested against Psychometrics Toolkit.

EKAdebo
EKAdebo previously approved these changes Mar 15, 2023
View reviewed changes
Copy link

@EKAdebo EKAdebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the 230315 beta against the Psychrometrics Toolkit Test Procedure. it passed the test with no errors

milogillot-BH
milogillot-BH previously approved these changes Mar 15, 2023
View reviewed changes
Copy link

@milogillot-BH milogillot-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Psychrometrics Toolkit Test Procedure followed

  • Sample grassshopper script executed with no errors or warnings.

  • Installer used: BuroHappold_BHoM_6.1.230315.beta.0

sherminmcclernon
sherminmcclernon previously approved these changes Mar 16, 2023
View reviewed changes
Copy link

@sherminmcclernon sherminmcclernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

230316 beta tested against Psychometrics Toolkit Testing Procedure and passed with no errors.

@FraserGreenroyd
Copy link

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 23 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 14:58.

ERROR CODE(s):

  • DF002.

DETAILS:

  • The main branch of this repository can NOT compile against the associated upstream dependencies if they are merged without this pull request. Not merging this pull request, but merging dependent repositories will result in compilation failures on the main branch of this repository..

@EKAdebo EKAdebo self-requested a review March 20, 2023 09:17
@FraserGreenroyd
Copy link

@BHoMBot check unit-tests

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

Erida-Bendo
Erida-Bendo reviewed Mar 21, 2023
View reviewed changes
Copy link

@Erida-Bendo Erida-Bendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test succeeded on BHoM_6.1.230315.beta,
script opens with no error and the Full test results panel returns pass.

@jamesramsden-bh jamesramsden-bh self-requested a review March 21, 2023 15:11
jamesramsden-bh
jamesramsden-bh approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed on beta dated 230321 and tested against Psychrometric Toolkit test procedure. Procedure passes fully with no further comment.

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
FraserGreenroyd
FraserGreenroyd approved these changes Mar 21, 2023
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the test procedures and testing undertaken on this repository, including unit tests. I am happy for this to be deployed to the 6.1 beta.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 21, 2023
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

2 similar comments
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 48 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling

There are 270 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 367 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

Please be advised that the check with reference 12202472629 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 30 additional annotations waiting, made up of 0 errors and 30 warnings.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 439 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit cf50671 into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erida-Bendo Erida-Bendo Erida-Bendo left review comments

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

@milogillot-BH milogillot-BH milogillot-BH left review comments

@sherminmcclernon sherminmcclernon sherminmcclernon left review comments

@EKAdebo EKAdebo Awaiting requested review from EKAdebo

Assignees

@bhombot-ci bhombot-ci[bot]

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@FraserGreenroyd @jamesramsden-bh @milogillot-BH @EKAdebo @sherminmcclernon @Erida-Bendo @BHoMBot @kprusicka