Skip to content

Remove ToUTMPolyLine Unit Test #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2022
Merged

Remove ToUTMPolyLine Unit Test #92

merged 3 commits into from
Nov 9, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #91

Tests passing when run locally.
Attempting fix by simply regenerating the tests to be checked on PR if now passing.

Test files

Changelog

Additional comments

@IsakNaslundBh
Regenerate TOUTMPolyLine Uts
532c23a 
Tests passing when run locally.
Attempting fix by simply regenerating the tests to be checked on PR if now passing.
@IsakNaslundBh IsakNaslundBh added the type:test-script Creation of unit test required label Nov 9, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

Based on the current use of this toolkit @IsakNaslundBh I'm tempted to say we just cull this UT from the batch and revisit it when the toolkit is more used by @michaelhoehn ?

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@IsakNaslundBh want to try third times the charm?

@IsakNaslundBh
removing failing UT
2d217cd 
-UT passing on local hence har to track down why crashing on remote
- Tk currently has relatively low usage, why UT not as critical to keep
- Can revert this commit at later stage to bring back the UT if/when required
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 29 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Regenerate TOUTMPolyLine Uts Remove ToUTMPolyLine Unit Test Nov 9, 2022
FraserGreenroyd
FraserGreenroyd approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is removed, hopefully this resolves it

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

There are 43 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 36 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 6b59092 into main Nov 9, 2022
@FraserGreenroyd FraserGreenroyd deleted the OpenStreetMap_Toolkit-#91-FixFailingUT branch November 9, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees
No one assigned
Labels
type:test-script Creation of unit test required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error occurred on a unit test
2 participants
@IsakNaslundBh @FraserGreenroyd