-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate Convert methods to Adapter, change Engine.Lusas namespace to Adapters.Lusas, add formatting to all documents and implement local versioning #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run Lusas_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
@peterjamesnugent Would you mind raising a PR on Versioning_Toolkit, covering the changes to Midas and Lusas. Can then either merge that one as is, or wait for others to join in with the external changes if needed. |
Now the versioning can be done locally on this toolkit, @peterjamesnugent , same as we did on XML_Toolkit? 😄 |
/azp run Lusas_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
… remove unused method
/azp run Lusas_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Lusas_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
Versioning works for changing the components to the latest versions. Potential accidental causes of incorrectly identifying modules as older than they are don't appear to lead to infinite looping. Considerations for future updates may include skipping version numbers where applicable. Some cells in JSON files left intentionally blank, may lead to slower processing, shouldn't be a problem at the current stage of development, but worth considering streamlining for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All functions tested with versioning perform adequately.
Versioning works for changing the components to the latest versions.
Potential accidental causes of incorrectly identifying modules as older than they are don't appear to lead to infinite looping of functions. (Deliberate forcing of errors was picked up by components.)
Considerations for future updates may include skipping version numbers where applicable. If no changes are made, or if changes are subsequently changed later, this will help speed up the processes especially with larger files.
Some of the cells in the JSON files are left intentionally blank, this may lead to slower processing than if they weren't included. However, they shouldn't be a problem at the current stage of development. (worth considering streamlining for the future.)
@calumlockhart-bh please review again, the namespaces have changed from External to Adapter as per: BHoM/BHoM_Adapter#213 It should be a case of just opening the script with the new build of Lusas_Toolkit and BHoM_UI. |
/azp run Lusas_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few instances of inefficient use of namespaces, but nothing to worry about.
Consider where changing "internal" to "private", what it is that you want to be accessible inside the assembly.
Issues addressed by this PR
Closes #236
Closes #239
Closes #247
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EjHwiuHBSGpJgmezKPl-UrAB2j6dvBUAkXNDrzl1qDcv9g?e=Zx7Wkw
Additional Comments
@calumlockhart-bh when reviewing there are a few things to check:
VersioningComponents.gh
all the components on the canvas should work, there should not be any error messages and all constructors should produce objectsPushPullTest.cs
, I just want to make sure in the porting of methods and changing of namespaces nothing has fallen through the cracksChangelog
.Lusas
namespace to.Adapters.Lusas
namespaceLusas_Engine
stored inVersioning_32.json
Convert
methods that use the LPI fromLusas_Engine
toLusas_Adapter